Fix deprecation warning on Price Set report #15952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 5.20 we added a deprecation warning on searches that are borked WRT filling the prev_next cache & hence doing searches. The price set search falls into this camp & while it has been broken forever the deprecation notice is new (& the fix is safe) so targettin 5.20
|
(Standard links)
|
|
Having stumbled on this kind of bug a few times, I think it's a safe fix and will be useful for those who write custom searches. (but I'll let Seamus review/merge) |
|
tested it and happy with it, I have also stumbled across 2 other custom searches that are generating the same notice, 1. Event Aggregate and 2. The basic Custom Search (why that exists i have no idea) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Removes a new deprecation notice from PriceSet Search
Before
After
Technical Details
In 5.20 we added a deprecation warning on searches that are borked WRT filling the prev_next
cache & hence doing searches. The price set search falls into this camp & while it has
been broken forever the deprecation notice is new (& the fix is safe) so targetting 5.20
Comments
@seamuslee001 - this is the one you found